Change in libosmocore[master]: stats_test: restore stat_item_get_next asserts

osmith gerrit-no-reply at lists.osmocom.org
Tue Apr 6 10:00:28 UTC 2021


Hello Jenkins Builder, pespin, daniel, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmocore/+/23509

to look at the new patch set (#2).

Change subject: stats_test: restore stat_item_get_next asserts
......................................................................

stats_test: restore stat_item_get_next asserts

This is a partial revert of b27b352e ("stats: Use a global index for
stat item values"). Now that osmo_stat_item_get_next correctly returns
how many values have been skipped, we can use the accurate asserts on
its return value again.

Fix the initial values of next_id_a,b (1 instead of 0), so we don't get
a skipped value on the first read. This is needed, because b27b352e
refactored osmo_stat_item_get_next to have the next id as parameter
instead of the last read one, and the initial value was not adjusted in
the tests.

Related: OS#5088
Change-Id: I9d4cda2487a62f52361c24058363dfa90e502c63
---
M tests/stats/stats_test.c
1 file changed, 18 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/23509/2
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23509
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9d4cda2487a62f52361c24058363dfa90e502c63
Gerrit-Change-Number: 23509
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210406/0b0b1d18/attachment.htm>


More information about the gerrit-log mailing list