Change in pysim[master]: Use zero padding for EF['ACC'] field

fixeria gerrit-no-reply at lists.osmocom.org
Mon Apr 5 15:39:30 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 )

Change subject: Use zero padding for EF['ACC'] field
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> The ``EF_ACC`` field defines the access control class (ACC) for a subscriber.
> 
> Current implementation adds padding 1 towards the most significant bits if the input is shorter than 2 bytes.
> 
> However, it should be padded with 0, otherwise additional ACCs are allocated to the subscriber. (Probably only a single bit shall be set to 1)
> 
> Excerpt from [ETSI TS 131 102, 4.2.15](https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/04.15.00_60/ts_131102v041500p.pdf):
> 
> ```
> EF_ACC: Two bytes: B1, B2
> 
> B1.b8...B1.b4: high priority users (class 15...11)
> B1.b3: always 0
> B1.b2...B1.b2 and B2.b7...B2.b0: normal priority users (class 9...0) - to be evenly distributed across subscribers
> ```
> 
> **Legend:** Byte X, bit Y: BX.bY

This description should be in the commit message.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23631
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1b8dc01a6c48adad1ed8158de59b12519ed688e9
Gerrit-Change-Number: 23631
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Falkenberg <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Apr 2021 15:39:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210405/3992aed7/attachment.htm>


More information about the gerrit-log mailing list