Change in simtrace2[master]: rename PIN_PHONE_IO to PIN_USIM1_IO

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 4 18:00:43 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23614 )

Change subject: rename PIN_PHONE_IO to PIN_USIM1_IO
......................................................................


Patch Set 1:

IMHO it doesn't make sense to rename only the IO pin but keep the "PHONE" name for the CLK and other #defines in that same file.

Furthermore, there's of course always the rationale to keep naming as close as possible to the naming in the schematics.

So in general, I'm not sure if we want to merge it. But if we do, then we want all PHONE to be renamed.


-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23614
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I486b14260faec897e8c8698c4b7987bf36492497
Gerrit-Change-Number: 23614
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tsaitgaist <kredon at sysmocom.de>
Gerrit-Comment-Date: Sun, 04 Apr 2021 18:00:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/ea13d4bc/attachment.htm>


More information about the gerrit-log mailing list