Change in simtrace2[master]: cardem: choose a more reasonable default ATR

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 4 17:55:00 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23611 )

Change subject: cardem: choose a more reasonable default ATR
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/simtrace2/+/23611/1/firmware/libcommon/source/card_emu.c 
File firmware/libcommon/source/card_emu.c:

https://gerrit.osmocom.org/c/simtrace2/+/23611/1/firmware/libcommon/source/card_emu.c@1199 
PS1, Line 1199: 0x59};
> missing space
Done


https://gerrit.osmocom.org/c/simtrace2/+/23611/1/host/src/simtrace2-cardem-pcsc.c 
File host/src/simtrace2-cardem-pcsc.c:

https://gerrit.osmocom.org/c/simtrace2/+/23611/1/host/src/simtrace2-cardem-pcsc.c@56 
PS1, Line 56: reasonable ATR offering all protocols and voltages
> Weird comment formatting. I would prefer to have it consistent with the GPL license header.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I1eebfdc06be55931c2e80e2b515ac3a559737c38
Gerrit-Change-Number: 23611
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sun, 04 Apr 2021 17:55:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/2f9e7dbf/attachment.htm>


More information about the gerrit-log mailing list