Change in osmo-bsc[master]: debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 4 16:20:35 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21644 )

Change subject: debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state
......................................................................

debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state

Before, it is not clear whether the RTP is already done setting up or
the RTP is skipped entirely. This log message clarifies that.

Change-Id: I18ffcf93e82ee47413e4b2f741ffbfbb18322e1d
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 9c7ecaf..6f0fd63 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -861,8 +861,13 @@
 
 	case LCHAN_EV_RLL_ESTABLISH_IND:
 		if (!lchan->activate.info.requires_voice_stream
-		    || lchan_rtp_established(lchan))
+		    || lchan_rtp_established(lchan)) {
+			LOG_LCHAN(lchan, LOGL_DEBUG,
+				  "%s\n",
+				  (lchan->activate.info.requires_voice_stream ?
+				   "RTP already established earlier" : "no voice stream required"));
 			lchan_fsm_state_chg(LCHAN_ST_ESTABLISHED);
+		}
 		return;
 
 	case LCHAN_EV_RTP_READY:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21644
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I18ffcf93e82ee47413e4b2f741ffbfbb18322e1d
Gerrit-Change-Number: 21644
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/2b70ceb5/attachment.htm>


More information about the gerrit-log mailing list