Change in pysim[master]: Move init_reader() from utils.py to transport/__init__.py

fixeria gerrit-no-reply at lists.osmocom.org
Sat Apr 3 23:09:12 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23596 )

Change subject: Move init_reader() from utils.py to transport/__init__.py
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23596/2/pySim/transport/__init__.py 
File pySim/transport/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/23596/2/pySim/transport/__init__.py@113 
PS2, Line 113: sl:Optional[LinkBase] = None
This is not going to work in EOL Python 3.5. I am personally fine with that, just letting you know since you do care about compatibility with Debian 9. To make it work, use the old syntax:

  sl = None # type: Optional[LinkBase]

Looks ugly, but all code linters support this too.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23596
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I168597ac14497fb188a15cb632f32452128bc1c6
Gerrit-Change-Number: 23596
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sat, 03 Apr 2021 23:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210403/56b50791/attachment.htm>


More information about the gerrit-log mailing list