Change in osmo-bsc[master]: Ignore CHANnel ReQuireD with Access Delay IE > 63

keith gerrit-no-reply at lists.osmocom.org
Sat Apr 3 00:03:05 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23574 )

Change subject: Ignore CHANnel ReQuireD with Access Delay IE > 63
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3//COMMIT_MSG@19 
PS3, Line 19: Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce
> Related: OS#5096
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/abis_rsl.c@1530 
PS3, Line 1530: LOGL_NOTICE
> not sure we want 'notice' on all of these, if this happens quite frequently on some BTSs. […]
Let's meet in the middle at INFO 😊

Most of the other similar logging here are abis_rsl.c is at INFO. I do find that DEBUG can be awfully verbose on a busy BTS, certainly with many facilities of interest at DEBUG is is impossible to actually read anything. I think of DEBUG as only for logging and later analysis, I think this is something I might want to see in real time while watching.

thanks for review!


https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/bsc_vty.c@2754 
PS3, Line 2754: BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK
> As far as I can see, this parameter applies immediately, so: […]
Good catch! :) the perils of copy&paste.. And I did even look at that at 3am and say,oh that's ok...
Thanks for review!


https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/bsc_vty.c@2755 
PS3, Line 2755: 	      "rach max-delay <0-127>",
> I think 1-127 or 1-255 is a reasonably permitted range. 0 is indeed odd.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce
Gerrit-Change-Number: 23574
Gerrit-PatchSet: 4
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 03 Apr 2021 00:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210403/5b7e3f82/attachment.htm>


More information about the gerrit-log mailing list