Change in pysim[master]: pySim-shell: Remove UsimCommands

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 2 20:13:53 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23583 )


Change subject: pySim-shell: Remove UsimCommands
......................................................................

pySim-shell: Remove UsimCommands

Those are a leftover of a very early attempt at pySim-shell, it has
long been superseded by all of the filesystem.py infrastructure.

Change-Id: I6b84ce205f46a1efd19087d332920982f17ca9cc
---
M pySim-shell.py
1 file changed, 1 insertion(+), 19 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/23583/1

diff --git a/pySim-shell.py b/pySim-shell.py
index c170398..931b5ea 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -54,7 +54,7 @@
 class PysimApp(cmd2.Cmd):
 	CUSTOM_CATEGORY = 'pySim Commands'
 	def __init__(self, card, rs, script = None):
-		basic_commands = [Iso7816Commands(), UsimCommands()]
+		basic_commands = [Iso7816Commands()]
 		super().__init__(persistent_history_file='~/.pysim_shell_history', allow_cli_args=False,
 				 use_ipython=True, auto_load_commands=False, command_sets=basic_commands, startup_script=script)
 		self.intro = style('Welcome to pySim-shell!', fg=fg.red)
@@ -346,24 +346,6 @@
 			raise RuntimeError("unable to export %i file(s)" % context['ERR'])
 
 
- at with_default_category('USIM Commands')
-class UsimCommands(CommandSet):
-	def __init__(self):
-		super().__init__()
-
-	def do_read_ust(self, _):
-		"""Read + Display the EF.UST"""
-		self._cmd.card.select_adf_by_aid(adf="usim")
-		(res, sw) = self._cmd.card.read_ust()
-		self._cmd.poutput(res[0])
-		self._cmd.poutput(res[1])
-
-	def do_read_ehplmn(self, _):
-		"""Read EF.EHPLMN"""
-		self._cmd.card.select_adf_by_aid(adf="usim")
-		(res, sw) = self._cmd.card.read_ehplmn()
-		self._cmd.poutput(res)
-
 def parse_options():
 
 	parser = OptionParser(usage="usage: %prog [options]")

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23583
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6b84ce205f46a1efd19087d332920982f17ca9cc
Gerrit-Change-Number: 23583
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/7349ab4f/attachment.htm>


More information about the gerrit-log mailing list