Change in pysim[master]: Add more documentation to the classes/methods

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 2 14:57:16 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23577 )

Change subject: Add more documentation to the classes/methods
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/filesystem.py 
File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/23577/2/pySim/filesystem.py@45 
PS2, Line 45: parent:'CardDF'=None
> The linters won't be happy about this, you need […]
Thanks a lot. However:

  File "/space/home/laforge/projects/git/pysim/pySim/filesystem.py", line 47, in CardFile
    parent:Optional('CardDF')=None):
  File "/usr/lib/python3.9/typing.py", line 335, in __call__
    raise TypeError(f"Cannot instantiate {self!r}")
TypeError: Cannot instantiate typing.Optional



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23577
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6ac88e0662cf3c56ae32d86d50b18a8b4150571a
Gerrit-Change-Number: 23577
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Fri, 02 Apr 2021 14:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/b55ed4d2/attachment.htm>


More information about the gerrit-log mailing list