Change in osmo-bsc[master]: Ignore CHANnel ReQuireD with Access Delay IE > 63

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 2 11:57:21 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23574 )

Change subject: Ignore CHANnel ReQuireD with Access Delay IE > 63
......................................................................


Patch Set 3:

(2 comments)

apart from the NOTICE I think it's good to get merged.

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/abis_rsl.c 
File src/osmo-bsc/abis_rsl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/abis_rsl.c@1530 
PS3, Line 1530: LOGL_NOTICE
not sure we want 'notice' on all of these, if this happens quite frequently on some BTSs.  In the end, it is you (Rhizomatica) who suffers most from all of these ending up in logs ;)

We do have the counter, which is great.  I personally wouldn't go beyond DEBUG for the log, but it's of course always a bit of a matter of taste.


https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23574/3/src/osmo-bsc/bsc_vty.c@2755 
PS3, Line 2755: 	      "rach max-delay <0-127>",
> Also, allowing 0 is strange.. This would essentially disable Access. […]
I think 1-127 or 1-255 is a reasonably permitted range. 0 is indeed odd.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23574
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie8987bcc0e43921bc753162b77a0efc68799b3ce
Gerrit-Change-Number: 23574
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 02 Apr 2021 11:57:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/751b6f6d/attachment.htm>


More information about the gerrit-log mailing list