Change in pysim[master]: commands, ts_102_221: replace pytlv with uttlv

merlinchlosta gerrit-no-reply at lists.osmocom.org
Fri Apr 2 09:14:34 UTC 2021


merlinchlosta has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23483 )

Change subject: commands, ts_102_221: replace pytlv with uttlv
......................................................................


Patch Set 4:

> The other thing: how would I encode an array of TLVs all with the same tag, and is the order preserved?
> ```
> t = FIX_TLV()
> t[0x80] = 123
> t[0x80] = 321
> ```
> This will of course just override the single 0x80 item.

Same applies for decoding, only the last element with a specific tag is decoded:
```
	t = FIX_TLV()
	t.parse_array([0x80, 0x01, 0xff, 0x80, 0x01, 0xee])
	print(t.tree())
	t.parse_array([0x81, 0x01, 0xff, 0x80, 0x01, 0xee])
	print(t.tree())
```
output:
```
80: ee

80: ee
81: ff
```

Expected:
```
80: ee
80: ff

80: ee
81: ff
```


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23483
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I971b818836aff2fbeb6769f819d496cee4bfa7cf
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Comment-Date: Fri, 02 Apr 2021 09:14:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210402/65ca03ca/attachment.htm>


More information about the gerrit-log mailing list