Change in osmo-ttcn3-hacks[master]: ggsn: Fix TC_pdp4_act_deact_with_single_dns()

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 1 19:31:12 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23571 )

Change subject: ggsn: Fix TC_pdp4_act_deact_with_single_dns()
......................................................................

ggsn: Fix TC_pdp4_act_deact_with_single_dns()

In TC_pdp4_act_deact_with_single_dns we activate, deactivate and then
re-activate a PDP context. Hoewver, we re-use the same variable and
don't reset the state in between.  This results in the second PDP CTX
activation to include an end-user-address (static IP allocation), which
OsmoGGSN doesn't implement.

Before osmo-ggsn Change-Id Iac8868438655fe4e5e07d167d7dbd6273dbb7678,
the test passed as osmo-ggsn simply ignored the requested static address.
After that change, we reject static addresses and hence the test starts
to fail.

Change-Id: I1b1869bc2cee39c8fddd8fa63f48bdaa6a65e462
Related: OS#5097
---
M ggsn_tests/GGSN_Tests.ttcn
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index be0e565..a0c7b16 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -1147,6 +1147,7 @@
 		f_pdp_ctx_del(ctx, '1'B);
 
 		/* PCO with secondary DNS only */
+		ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn)));
 		ctx.pco_req := valueof(ts_PCO_IPv4_SEC_DNS_IPCP);
 		f_pdp_ctx_act(ctx);
 		pco_neg_dns := f_PCO_extract_proto(ctx.pco_neg, '8021'O, 1);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23571
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1b1869bc2cee39c8fddd8fa63f48bdaa6a65e462
Gerrit-Change-Number: 23571
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210401/d939ce54/attachment.htm>


More information about the gerrit-log mailing list