Change in pysim[master]: filesystem: allow selection of arbitrary files
gerrit-no-reply at lists.osmocom.org
Thu Apr 1 15:35:15 UTC 2021
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23533 )
Change subject: filesystem: allow selection of arbitrary files
Patch Set 3:
> Patch Set 1:
> I'm sorry, I don't like that approach. I always thought we should support arbitrary files, but not by users creating it on the command line. I think we should try to be more elegant without requiring the user to specify things we can discover.
> Alternative, for example: Simply allow the user to select any FID (two-digit hex number), and then use the FCP returned by the card to create an EF instance of proper nature (transparent / record / size / ...).
> Another idea is to have some kind of configuration file (similar to the idea with regard to the ADM/PIN) where users can configure more files. But TBH, I would rather prefer writing proper python code for all the relevant files.
> I also don't think it's worth investing sysmocom time on this at the moment.
I have now integrated the functionality of add_ef into select. I also think that this is better.
To view, visit https://gerrit.osmocom.org/c/pysim/+/23533
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 01 Apr 2021 15:35:15 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log