Change in pysim[master]: Surround by try except to continue programming of other parameters

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Sep 30 11:57:35 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/20313 )

Change subject: Surround by try except to continue programming of other parameters
......................................................................


Patch Set 1:

I think the problem with this is that the exit() code of the program now is always "success" (0) even if there were any errors.  This is very dangerous if you use some scripts to determine success/failure of the programming operation.

If we go your approach, then we need to make sure that if any exceptions were raised, we need to memorize that and terminate the program with an error exit code.

Also, any error messages should always be printed to stderr, not to stdout (which you are doing here).  Either change to stderr, or maybe consider introducing the general python logging framework here, which should hopefully make sure error-level messages are actually printed to stderr.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/20313
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5a200e0594dc29cb6fdaf8966f4a11adeddcd80f
Gerrit-Change-Number: 20313
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 30 Sep 2020 11:57:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200930/8c492ef0/attachment.htm>


More information about the gerrit-log mailing list