This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20304 ) Change subject: logging: Introduce MAX_LOG_SIZE for the magic number 4096 ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/20304/1/src/logging.c File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/20304/1/src/logging.c@59 PS1, Line 59: /* maximum length of the log string of a single log event (typically line) */ simply add length .. "including the terminating NUL character"? https://gerrit.osmocom.org/c/libosmocore/+/20304/1/src/logging.c@396 PS1, Line 396: MAX_LOG_SIZE > Ack yes, but I'm not changing that size. Should I just adjust the comment above the #define? OR are you saying the #define should be 4095 and there should be a +1 here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20304 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia9645098dffecd29242857de8f1aea6b9aca5918 Gerrit-Change-Number: 20304 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 29 Sep 2020 17:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200929/31426221/attachment.htm>