This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20274 ) Change subject: ns2: fix a msg leak when receiving REJECTED messages ...................................................................... ns2: fix a msg leak when receiving REJECTED messages Change-Id: I7edc53c29c3dd09c395a275ceb8648b8eb19c06c --- M src/gb/gprs_ns2_frgre.c M src/gb/gprs_ns2_udp.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/src/gb/gprs_ns2_frgre.c b/src/gb/gprs_ns2_frgre.c index e2e0b29..e0797b6 100644 --- a/src/gb/gprs_ns2_frgre.c +++ b/src/gb/gprs_ns2_frgre.c @@ -453,8 +453,8 @@ goto out; case GPRS_NS2_CS_REJECTED: /* nsip_sendmsg will free reject */ - frgre_sendmsg(bind, reject, &saddr); - return 0; + rc = frgre_sendmsg(bind, reject, &saddr); + goto out; case GPRS_NS2_CS_CREATED: frgre_alloc_vc(bind, nsvc, &saddr, dlci); gprs_ns2_vc_fsm_start(nsvc); diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c index bda0acf..251f869 100644 --- a/src/gb/gprs_ns2_udp.c +++ b/src/gb/gprs_ns2_udp.c @@ -202,8 +202,8 @@ goto out; case GPRS_NS2_CS_REJECTED: /* nsip_sendmsg will free reject */ - nsip_sendmsg(bind, reject, &saddr); - return 0; + rc = nsip_sendmsg(bind, reject, &saddr); + goto out; case GPRS_NS2_CS_CREATED: ns2_driver_alloc_vc(bind, nsvc, &saddr); gprs_ns2_vc_fsm_start(nsvc); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20274 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7edc53c29c3dd09c395a275ceb8648b8eb19c06c Gerrit-Change-Number: 20274 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200926/0ca41567/attachment.htm>