Change in osmo-msc[master]: Convert paging response timer into an osmocom own X4 timer

[lynxis lazus]

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/20280 )

Change subject: Convert paging response timer into an osmocom own X4 timer
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/20280/3/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/20280/3/src/libmsc/msc_vty.c@581 
PS3, Line 581: 	for (rat=0; rat<OSMO_RAT_COUNT; rat++) {
> spacing
I would love to have a gerrit plugin doing it. The coreboot review has something like that.


https://gerrit.osmocom.org/c/osmo-msc/+/20280/3/src/libmsc/msc_vty.c@585 
PS3, Line 585: 	vty_out(vty, "%% paging response-timer is deprecated.%s"
> Better print it in one output line, no need to bomb with several lines
IMHO it's more readable in multiple lines.
Having it all in one line would mean it's over 80 char/line. It's also deprecated.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/20280
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic050eb49ba0c5811b43d8d8b44145a1115fd8546
Gerrit-Change-Number: 20280
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 26 Sep 2020 19:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200926/01e9bd7c/attachment.htm>