This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20272 ) Change subject: Introduce the new OML NM_ATT_OSMO_NS_LINK_CFG to configure IPv6 NSVC for PCU ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1291 PS1, Line 1291: case IPPROTO_IPIP: Again, this kind of define being used here makes no sense to me, it's confusing. Let's better use our own define. https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1292 PS1, Line 1292: /* we already checked for 10 bytes */ No TLVP_LEN check here, as done in ipv6? https://gerrit.osmocom.org/c/osmo-bts/+/20272/1/src/common/oml.c@1295 PS1, Line 1295: memcpy(&nsvc->remote.u.sin.sin_addr.s_addr, cur, sizeof(in_addr_t)); memcopying into sin_addr and using sizeof(struct sin_addr) is what we usually use, and may be more portable? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I310699fabbfec4255f0474f31717f215c1201eca Gerrit-Change-Number: 20272 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 25 Sep 2020 09:53:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200925/58e762d7/attachment.htm>