Change in libosmocore[master]: ns2: check the specific bit of NS SDU Control bits

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Sep 25 09:45:25 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20266 )

Change subject: ns2: check the specific bit of NS SDU Control bits
......................................................................

ns2: check the specific bit of NS SDU Control bits

Change-Id: I9632abe70585cb7aff2602590453d903dd88b48a
---
M src/gb/gprs_ns2_vc_fsm.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  daniel: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c
index 7b07a49..d13f1ce 100644
--- a/src/gb/gprs_ns2_vc_fsm.c
+++ b/src/gb/gprs_ns2_vc_fsm.c
@@ -473,7 +473,8 @@
 	nsp.bvci = bvci;
 	nsp.nsei = priv->nsvc->nse->nsei;
 
-	if (nsh->data[0])
+	/* 10.3.9 NS SDU Control Bits */
+	if (nsh->data[0] & 0x1)
 		nsp.u.unitdata.change = NS_ENDPOINT_REQUEST_CHANGE;
 
 	osmo_prim_init(&nsp.oph, SAP_NS, PRIM_NS_UNIT_DATA,

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20266
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9632abe70585cb7aff2602590453d903dd88b48a
Gerrit-Change-Number: 20266
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200925/357a543a/attachment.htm>


More information about the gerrit-log mailing list