This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/20265 ) Change subject: ns2: remove bssgp specific msgb->cb parts ...................................................................... ns2: remove bssgp specific msgb->cb parts There shouldn't be any knowledge of the upper layer in the NS layer. The PCU / SGSN / gbproxy have to add the pointer when parsing the primitives. Change-Id: Id7edb8feb96436ba170383fc62d43ceb16955d53 --- M src/gb/gprs_ns2_vc_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/20265/1 diff --git a/src/gb/gprs_ns2_vc_fsm.c b/src/gb/gprs_ns2_vc_fsm.c index 33a0328..7b07a49 100644 --- a/src/gb/gprs_ns2_vc_fsm.c +++ b/src/gb/gprs_ns2_vc_fsm.c @@ -469,9 +469,9 @@ /* TODO: nsh->data[0] -> C/R only valid in IP SNS */ bvci = nsh->data[1] << 8 | nsh->data[2]; - msgb_bssgph(msg) = &nsh->data[3]; - msgb_bvci(msg) = nsp.bvci = bvci; - msgb_nsei(msg) = nsp.nsei = priv->nsvc->nse->nsei; + msg->l3h = &nsh->data[3]; + nsp.bvci = bvci; + nsp.nsei = priv->nsvc->nse->nsei; if (nsh->data[0]) nsp.u.unitdata.change = NS_ENDPOINT_REQUEST_CHANGE; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7edb8feb96436ba170383fc62d43ceb16955d53 Gerrit-Change-Number: 20265 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200923/19cab3d4/attachment.htm>