This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/20259 ) Change subject: add osmo_sccp_addr_to_str_c osmo_sccp_inst_addr_to_str_c ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/20259/1/src/sccp_helpers.c File src/sccp_helpers.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/20259/1/src/sccp_helpers.c@323 PS1, Line 323: OSMO_STRBUF_PRINTF(sb, ",PC=%s", osmo_ss7_pointcode_print(ss7, addr->pc)); > ss7=NULL is safe here? I only changed append_to_buf to OSMO_STRBUF_PRINTF, no idea really https://gerrit.osmocom.org/c/libosmo-sccp/+/20259/1/src/sccp_helpers.c@363 PS1, Line 363: /* Rather use osmo_sccp_inst_addr_to_str_buf() or osmo_sccp_inst_addr_to_str_c() to not use a static buffer. > Better but this below, not in first line where it's explained what the function does. i thought it's better to see right away to rather look elsewhere. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/20259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia7f9d891ea92abd20855374b936aac8b28ae15df Gerrit-Change-Number: 20259 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 23 Sep 2020 19:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200923/db4e653e/attachment.htm>