Change in osmo-hlr[master]: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed Sep 23 13:28:06 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/19914 )

Change subject: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy"
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/19914/5/src/hlr_db_tool.c 
File src/hlr_db_tool.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/19914/5/src/hlr_db_tool.c@523 
PS5, Line 523: 	/* db_close wiill only finalize statments in
'wiill'

it is ok to use 120 line width


https://gerrit.osmocom.org/c/osmo-hlr/+/19914/5/src/hlr_db_tool.c@527 
PS5, Line 527: 		sqlite3_finalize(hlr_db_stmt[i]);
nice, i didn't realize / forgot about this one



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/19914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ic47e549be3551ae43ab6a84228d47ae03e9652a6
Gerrit-Change-Number: 19914
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Sep 2020 13:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200923/ea563a1a/attachment.htm>


More information about the gerrit-log mailing list