Change in osmo-ttcn3-hacks[master]: pcu: Check stats for pcu channel allocation, bytes transferred

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Sep 22 19:27:29 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20226 )

Change subject: pcu: Check stats for pcu channel allocation, bytes transferred
......................................................................


Patch Set 3: Code-Review+1

> I'm clearly with fixeria here.  A test should generally try to focus on testing one thing.  Sure, you always have underlying protocols and state that you need to reach, but weshould avoid testing tons of unrelated stuff.

having stated that, I think counters are slightly different, as they are mostly a by-product of some other action/procedure, rather than one by themselves.  So I think it's ok to do "drive-by counter checking".


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20226
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I90964b32fa11ed2582afc5fb56bd302b06606f86
Gerrit-Change-Number: 20226
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Sep 2020 19:27:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200922/718ffdcc/attachment.htm>


More information about the gerrit-log mailing list