Change in osmo-mgw[master]: mgcp_vty: deprecate bind early command

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Sep 22 19:07:52 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20248 )

Change subject: mgcp_vty: deprecate bind early command
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/20248/1/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/20248/1/src/libosmo-mgcp/mgcp_vty.c@451 
PS1, Line 451: CMD_WARNING
> Shouldn't we return CMD_SUCCESS instead? CMD_WARNING would trigger a configuration parsing error, AF […]
CMD_ERROR ends config file parsing, but CMD_WARNING shouldn't, AFAIR.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20248
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I594a87d2f63826a9d7b4f6a380586b08b3b79518
Gerrit-Change-Number: 20248
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Sep 2020 19:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200922/16c2b0c9/attachment.htm>


More information about the gerrit-log mailing list