This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20249 ) Change subject: mgcp_e1: do not expose function mgcp_e1_init() ...................................................................... mgcp_e1: do not expose function mgcp_e1_init() The initialization of the E1 line in mgcp_e1.c is controlled internally, there is no need to expose the function mgcp_e1_init(), lets make it static and remove the prefix mgcp_ Change-Id: I6aba1c55c9b1d729709ee1fba2994c77bd848a9b --- M include/osmocom/mgcp/mgcp_e1.h M src/libosmo-mgcp/mgcp_e1.c 2 files changed, 2 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/49/20249/1 diff --git a/include/osmocom/mgcp/mgcp_e1.h b/include/osmocom/mgcp/mgcp_e1.h index a4ae854..f0cf3ec 100644 --- a/include/osmocom/mgcp/mgcp_e1.h +++ b/include/osmocom/mgcp/mgcp_e1.h @@ -21,7 +21,6 @@ static const uint8_t e1_rates[] = { 64, 32, 32, 16, 16, 16, 16, 8, 8, 8, 8, 8, 8, 8, 8 }; static const uint8_t e1_offsets[] = { 0, 0, 4, 0, 2, 4, 6, 0, 1, 2, 3, 4, 5, 6, 7 }; -int mgcp_e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr); int mgcp_e1_endp_equip(struct mgcp_endpoint *endp, uint8_t ts, uint8_t ss, uint8_t offs); void mgcp_e1_endp_update(struct mgcp_endpoint *endp); void mgcp_e1_endp_release(struct mgcp_endpoint *endp); diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c index 50a2d85..7d4a29e 100644 --- a/src/libosmo-mgcp/mgcp_e1.c +++ b/src/libosmo-mgcp/mgcp_e1.c @@ -361,11 +361,7 @@ e1_send(ts, trunk); } -/*! Find an endpoint by its name on a specified trunk. - * \param[in] trunk trunk configuration. - * \param[in] ts_nr E1 timeslot number. - * \returns -EINVAL on failure, 0 on success. */ -int mgcp_e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr) +static int e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr) { /*! Each timeslot needs only to be configured once. The Timeslot then * stays open and permanently receives data. It is then up to the @@ -517,7 +513,7 @@ endp->e1.last_amr_ft = AMR_4_75; /* Set up E1 line / timeslot */ - rc = mgcp_e1_init(endp->trunk, ts); + rc = e1_init(endp->trunk, ts); if (rc != 0) return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20249 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6aba1c55c9b1d729709ee1fba2994c77bd848a9b Gerrit-Change-Number: 20249 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200922/ea6f61f7/attachment.htm>