Change in osmo-msc[master]: Don't Store an SMS in the database when the ESME is not Bound

[keith]

keith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19935 )

Change subject: Don't Store an SMS in the database when the ESME is not Bound
......................................................................

Don't Store an SMS in the database when the ESME is not Bound

We may never be able to deliver this SMS if it depends on the ESME, as we will
not resubmit the SMS to the ESME. Better to reject it at this time and have the MS
try again later.

Change-Id: I2c50904349dd4ed229b60b8468d776b817c0bd44
Related: OS#4740
---
M src/libmsc/gsm_04_11.c
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  keith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 5c26929..e5063dc 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -633,6 +633,16 @@
 	if (gsms->smpp.esme) {
 		return -EINPROGRESS;
 	}
+
+	/* This SMS got routed through SMPP, but the configured ESME was
+	 * unavailable at this time. This is an OOO condition.
+	 * Don't store this SMS in the database as we may never be
+	 * able to deliver it. (we would need to process the stored SMS and
+	 * attempt re-submission to the ESME)
+	 */
+	if (rc == GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER)
+		return rc;
+
 	/*
 	 * This SMS got routed through SMPP or no receiver exists.
 	 * In any case, we store it in the database for further processing.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2c50904349dd4ed229b60b8468d776b817c0bd44
Gerrit-Change-Number: 19935
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Assignee: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200922/d1ae9bd1/attachment.htm>