Change in osmo-sgsn[master]: Fix Radio Priority in MM Attach and PDP Context Activation

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20217 )

Change subject: Fix Radio Priority in MM Attach and PDP Context Activation
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/20217/1/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/20217/1/src/sgsn/gprs_gmm.c@305 
PS1, Line 305: 0x44
> Why 0x44?
the quick answer, I noted in wireshark two radio priorities here:

    Radio Priority 2 - Radio priority for TOM8
        .100 .... = Radio Priority (TOM8): priority level 4 (lowest) (4)
    Radio Priority - Radio priority for SMS
        .... .100 = Radio Priority (PDP or SMS): priority level 4 (lowest) (4)


Radio Priority 2 used to be .000 (above is with this patch) - Without following the code too much, but seeing that
 struct gsm48_attach_ack {...} 
has only one field for radio_prio, I guessed that this uint8_t 
corresponds to both and that the intention is that 'TOM8' should also be priority 4, best to set it seeing as how the MTK does not like this IE being 000



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20217
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I810cd541eb5764ee3f2c238bcd3a10836228d0b5
Gerrit-Change-Number: 20217
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Sun, 20 Sep 2020 23:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200920/7c36a7ec/attachment.htm>