This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19916 ) Change subject: mgcp_client: Allow setting IPv6 addresses ...................................................................... mgcp_client: Allow setting IPv6 addresses Change-Id: I257218b2ad7cbdd0ac4ae7fa75802bed74ce983f --- M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp-client/mgcp_client_vty.c 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve; Verified laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index df84226..72068b4 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -794,7 +794,7 @@ /* Initalize socket with the currently configured port * number */ - rc = osmo_sock_init2_ofd(&wq->bfd, AF_INET, SOCK_DGRAM, IPPROTO_UDP, mgcp->actual.local_addr, + rc = osmo_sock_init2_ofd(&wq->bfd, AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, mgcp->actual.local_addr, mgcp->actual.local_port, mgcp->actual.remote_addr, mgcp->actual.remote_port, OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); if (rc > 0) diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index d4e78f1..70fea5a 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -36,9 +36,10 @@ struct mgcp_client_conf *global_mgcp_client_conf = NULL; DEFUN(cfg_mgw_local_ip, cfg_mgw_local_ip_cmd, - "mgw local-ip A.B.C.D", + "mgw local-ip " VTY_IPV46_CMD, MGW_STR "local bind to connect to MGW from\n" - "local bind IP address\n") + "local bind IPv4 address\n" + "local bind IPv6 address\n") { if (!global_mgcp_client_conf) return CMD_ERR_NOTHING_TODO; @@ -69,9 +70,10 @@ "local bind port\n") DEFUN(cfg_mgw_remote_ip, cfg_mgw_remote_ip_cmd, - "mgw remote-ip A.B.C.D", + "mgw remote-ip " VTY_IPV46_CMD, MGW_STR "remote IP address to reach the MGW at\n" - "remote IP address\n") + "remote IPv4 address\n" + "remote IPv6 address\n") { if (!global_mgcp_client_conf) return CMD_ERR_NOTHING_TODO; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I257218b2ad7cbdd0ac4ae7fa75802bed74ce983f Gerrit-Change-Number: 19916 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200908/ebd53140/attachment.htm>