Change in osmo-ttcn3-hacks[master]: SGSN: introduce NS tests

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20008 )

Change subject: SGSN: introduce NS tests
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20008/1/sgsn/gen_links.sh 
File sgsn/gen_links.sh:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20008/1/sgsn/gen_links.sh@98 
PS1, Line 98: 
            : DIR=../pcu
            : FILES="RAW_NS.ttcn SGSN_Components.ttcn GPRS_Context.ttcn "
            : gen_links $DIR $FILES
I don't think we ever link some files that are not in library or in one of the dependency modules (Ericsson repositories).

I'm not saying this is a strict rule, but at least it's something that needs to be reviewed carefully if we want to go there.  I guess nobody editing some code in sgsn/ expects tests in other directories to break, for example.

For RAW_NS, I see no reason why it cannot simply be moved to ../library.  For the others, it requires review.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20008
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2bffbb110961474928f35d212cb492d4b6fdee0
Gerrit-Change-Number: 20008
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 07 Sep 2020 06:50:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200907/470425cc/attachment.htm>