Change in osmo-pcu[master]: BSSGP: use tlvp_val8() in gprs_bssgp_pcu_rx_paging_cs()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Oct 31 12:58:08 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20986 )

Change subject: BSSGP: use tlvp_val8() in gprs_bssgp_pcu_rx_paging_cs()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20986/1/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/20986/1/src/gprs_bssgp_pcu.cpp@212 
PS1, Line 212: 	return BTS::main_bts()->add_paging(tlvp_val8(tp, BSSGP_IE_CHAN_NEEDED, 0), &mi);
> Shouldn't we check whether the IE is there and otherwise print log or reject somehow?
According to 3GPP TS 48.018, table 10.3.2, this is an optional IE, so no.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20986
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic1e37cb9938323c9b9f0466be5cf7251a6db1008
Gerrit-Change-Number: 20986
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 31 Oct 2020 12:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201031/623548dd/attachment.htm>


More information about the gerrit-log mailing list