This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968 ) Change subject: pcu: Add infra to handle multitrx and multits envs ...................................................................... Patch Set 2: Code-Review-1 (10 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@205 PS2, Line 205: uint10_t GsmArfcn https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@213 PS2, Line 213: uint10_t GsmArfcn https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@370 PS2, Line 370: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@375 PS2, Line 375: arfcn != 0 ARFCN 0 is a valid ARFCN. Maybe rather make it 'optional' and call ispresent() here? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@379 PS2, Line 379: trx_nr := 7; I am afraid it would be hard to debug this if some day we decide to add some new hopping test cases, so I would setverdict(fail, ...) and call f_shutdown() here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@384 PS2, Line 384: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@386 PS2, Line 386: uint3_t You're using restricted types without the need... Maximum number of slots would be 8, while the UINT8_MAX is 7. Let's better use integer. It's not a protocol definition after all. P.S. I am now wondering how TITAN handles integer overflows. Would it throw a DTE? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@401 PS2, Line 401: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@415 PS2, Line 415: inout in (a.k.a. the 'const') https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968/2/pcu/GPRS_Components.ttcn@417 PS2, Line 417: uint3_t Again, integer overflow if pdch_mask == '11111111'B. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I28430e6d8c77d2b7dc630d186d425a5d82587b82 Gerrit-Change-Number: 20968 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Sat, 31 Oct 2020 11:42:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201031/df1acbe4/attachment.htm>