Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_multislot_tbf

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Oct 28 23:12:28 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947 )

Change subject: pcu: Introduce test TC_dl_multislot_tbf
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/1/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/1/pcu/GPRS_Components.ttcn@333 
PS1, Line 333: inout
You don't change 'dl_tbf' in this function, thus 'in'.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/1/pcu/GPRS_Components.ttcn@364 
PS1, Line 364: inout
You don't change 'ul_tbf' in this function, thus 'in'.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947/1/pcu/PCU_Tests.ttcn@1717 
PS1, Line 1717: 4
We want to verify expected behavior here, not the actual (potentially incorrect), right? Let's expect 8.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I417953a4c89dec82500b3b66f08ed648d266d813
Gerrit-Change-Number: 20947
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Oct 2020 23:12:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201028/d00d8419/attachment.htm>


More information about the gerrit-log mailing list