Change in osmo-sim-auth[master]: Fix pycodestyle issues

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Oct 28 17:25:32 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sim-auth/+/20908 )

Change subject: Fix pycodestyle issues
......................................................................

Fix pycodestyle issues

osmo-sim-auth.py:45:12: E711 comparison to None should be 'if cond is None:'
osmo-sim-auth.py:131:20: E712 comparison to True should be 'if cond is True:' or 'if cond:'

Change-Id: I959ea84b8369a0a37bb65c47824a4c4e8d4630cc
---
M osmo-sim-auth.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified
  fixeria: Looks good to me, approved



diff --git a/osmo-sim-auth.py b/osmo-sim-auth.py
index e05c384..f668dd4 100755
--- a/osmo-sim-auth.py
+++ b/osmo-sim-auth.py
@@ -42,7 +42,7 @@
 
     print("\nUMTS Authentication")
     ret = u.authenticate(rand_bin, autn_bin, ctx='3G')
-    if ret == None:
+    if ret is None:
         print("UMTS Authentication failed")
         exit(1)
     if len(ret) == 1:
@@ -128,7 +128,7 @@
     if options.autn:
         autn_bin = stringToByte(a2b_hex(options.autn))
 
-    if options.sim == True:
+    if options.sim is True:
         handle_sim(options, rand_bin)
     else:
         if not options.autn:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sim-auth/+/20908
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sim-auth
Gerrit-Branch: master
Gerrit-Change-Id: I959ea84b8369a0a37bb65c47824a4c4e8d4630cc
Gerrit-Change-Number: 20908
Gerrit-PatchSet: 2
Gerrit-Owner: rousseau <ludovic.rousseau+osmocom at free.fr>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201028/b3aa2e41/attachment.htm>


More information about the gerrit-log mailing list