Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Oct 27 23:10:28 UTC 2020


dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 )

Change subject: sched_lchan_tchf: count measurements for FACCH/F only once
......................................................................

sched_lchan_tchf: count measurements for FACCH/F only once

When the FACCH is generated (while in SPEECH mode), there is also a
fake speech indication handed up to l1sap.c. We must make sure that only
one of the two indications carry a measurement value, so lets invalidate
the measurement values (RSSI in particular) for the generated TCH
indication.

Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b
Related: OS#4799
---
M src/osmo-bts-trx/sched_lchan_tchf.c
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c
index 9c5bfc2..b1453dc 100644
--- a/src/osmo-bts-trx/sched_lchan_tchf.c
+++ b/src/osmo-bts-trx/sched_lchan_tchf.c
@@ -241,6 +241,16 @@
 			meas_avg.rssi, meas_avg.toa256,
 			meas_avg.ci_cb, ber10k,
 			PRES_INFO_UNKNOWN);
+
+		/* If we are in SPEECH mode we will generate a fake (BFI) TCH
+		 * indication as well. This indication is needed by the higher
+		 * layers, however we already have reported the measurement
+		 * result for the current block together with the FACCH.
+		 * To avoid reporting the same measurement result again with
+		 * the fake (BFI) TCH indication we set meas_avg.rssi to zero.
+		 * Doing so tells l1sap.c to ignore the measurement result. */
+		meas_avg.rssi = 0;
+
 bfi:
 		if (rsl_cmode == RSL_CMOD_SPD_SPEECH) {
 			/* indicate bad frame */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b
Gerrit-Change-Number: 20841
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/00fafef9/attachment.htm>


More information about the gerrit-log mailing list