Change in osmo-bts[master]: sched_lchan_tchf: count measurements for FACCH/F only once

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Oct 27 21:25:23 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20841 )

Change subject: sched_lchan_tchf: count measurements for FACCH/F only once
......................................................................


Patch Set 4:

(2 comments)

(send comments)

https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c 
File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c@245 
PS3, Line 245: If we are in SPEECH mode
> Or maybe we should avoid memset() here by adding a boolean flag 'dummy' to 'struct l1sched_meas_set' […]
We could also just set meas_avg.rssi = 0. That has the same effect.


https://gerrit.osmocom.org/c/osmo-bts/+/20841/3/src/osmo-bts-trx/sched_lchan_tchf.c@311 
PS3, Line 311: bfi_flag ? bi->toa256 : meas_avg.toa256
> I think this is still a problem.
Hmm. I do not understand what the problem exactly is. We do not set the bfi_flag, this means bfi_flag = false, which means that meas_avg.toa256 is used.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f2e620ba2a2ab2fecdbae627ef01c6128fce0b
Gerrit-Change-Number: 20841
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 27 Oct 2020 21:25:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/f60ccb15/attachment.htm>


More information about the gerrit-log mailing list