This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20919 ) Change subject: alloc_algo_b: Select TRX with least assigned TFIs during TBF alloc ...................................................................... Patch Set 3: Code-Review+1 (5 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/20919/3/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20919/3/src/bts.cpp@539 PS3, Line 539: uint8_t TFI is a value in range 0..31, so 32 unique values for each timeslot => 8 * 32 == 256. 256 > UINT8_MAX, so maybe unsigned int would be better? https://gerrit.osmocom.org/c/osmo-pcu/+/20919/3/src/bts.cpp@548 PS3, Line 548: 8 cosmetic: ARRAY_SIZE(trx->pdch)? https://gerrit.osmocom.org/c/osmo-pcu/+/20919/3/src/bts.cpp@557 PS3, Line 557: (uint8_t)-1 So it's basically 0xff? Let's maybe add a #define? https://gerrit.osmocom.org/c/osmo-pcu/+/20919/3/src/bts.cpp@562 PS3, Line 562: uint32_t cosmetic: sizeof(mask) would be cleaner https://gerrit.osmocom.org/c/osmo-pcu/+/20919/3/src/bts.cpp@562 PS3, Line 562: *8 ; coding style -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iccfc8acfbfdc258ed16cc5af01f12b376fe73b72 Gerrit-Change-Number: 20919 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 27 Oct 2020 13:10:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/d01b5a6c/attachment.htm>