Change in osmo-bsc[master]: bsc_subscr_conn_fsm: use cause code PREEMPTION on lchan loss

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20924 )

Change subject: bsc_subscr_conn_fsm: use cause code PREEMPTION on lchan loss
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20924/2/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20924/2/src/osmo-bsc/bsc_subscr_conn_fsm.c@377 
PS2, Line 377: 			gsc
I think the problem is that this code doesn't distinguish on _why_ the lchan disappeared.  So the EQUIPMENT_FAILURE might be correct for some other situations (maybe?).

I really don't think you can make the a ssumption that the only reson the lchan disappeared is pre-emption.

Think about a situation where the radio link fails before a (very slow) MSC is confirming the SCCP connection.  In that case the correct cause value would be radio link failure related, and neither of the two above is correct.

I think we need to be better than random guessing what might be the reason of the lchan disappearance.


https://gerrit.osmocom.org/c/osmo-bsc/+/20924/2/src/osmo-bsc/bsc_subscr_conn_fsm.c@742 
PS2, Line 742: 	/* Request a Clear Command from the MSC. */
             : 			gscon_bssmap_clear(conn, GSM0808_CAUSE_PREEMPTION);
             : 			break;
same here.


https://gerrit.osmocom.org/c/osmo-bsc/+/20924/2/src/osmo-bsc/bsc_subscr_conn_fsm.c@786 
PS2, Line 786: 	gscon_bssmap_clear(conn, GSM0808_CAUSE_PREEMPTION);
             : }
and here obviously.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20924
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I88b47695877a31bc5ede1080027c9c6080eb2090
Gerrit-Change-Number: 20924
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 27 Oct 2020 07:52:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/262af256/attachment.htm>