This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20926 ) Change subject: ns2: add value strings for ns2_affecting_cause_prim_str & ns2_prim_str ...................................................................... Patch Set 1: Code-Review-1 (6 comments) https://gerrit.osmocom.org/c/libosmocore/+/20926/1/include/osmocom/gprs/gprs_ns2.h File include/osmocom/gprs/gprs_ns2.h: https://gerrit.osmocom.org/c/libosmocore/+/20926/1/include/osmocom/gprs/gprs_ns2.h@39 PS1, Line 39: const char *gprs_ns2_prim_str(unsigned int cause); Usually, such functions are defined right in the header as 'static inline'. https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@207 PS1, Line 207: { NS > i guess those are straight from the spec? I find it a bit inconsistent that Virtual-Circuit is expa […] Ack https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@212 PS1, Line 212: { NS_AFF_CAUSE_SNS_FAILURE, "NSE SNS failure" }, Not terminated. https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@218 PS1, Line 218: enum ns_cause _cause = cause; Wait, how is this supposed to work...? https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@225 PS1, Line 225: { PRIM_NS_STATUS, "STATUS" }, Not terminated. https://gerrit.osmocom.org/c/libosmocore/+/20926/1/src/gb/gprs_ns2.c@229 PS1, Line 229: unsigned int Why not to use 'enum ns_cause' as type of the argument? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibf610fbd929dddc4a4e235152447caff522d4eb2 Gerrit-Change-Number: 20926 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 27 Oct 2020 07:50:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/872e5dc0/attachment.htm>