This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923 ) Change subject: PCU_Tests_SNS: improve SGSN originated BVC-RESETs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923/1/pcu/PCU_Tests_SNS.ttcn File pcu/PCU_Tests_SNS.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923/1/pcu/PCU_Tests_SNS.ttcn@290 PS1, Line 290: / should we really ignore all other PDUs? If all we care about is a BVC-RESET in the opposite direction, then we should only ignore those. Ignoring "any" packet from the peer has the risk of masking all kinds of failures, exactly why we want to have a test. Maybe turn the "ignore_other_pdu" into a "template PDU_NS ignore_rx_pdu" parameter. If it is "omit", we don't ignore anything. And if it is some other template, then we ignore anything matching the template specified by the caller - which in this case would be just a BVC-RESET, if I understand corectly. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id681749d75073c1d50a4b0a2e86f0a2dd0955b45 Gerrit-Change-Number: 20923 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 27 Oct 2020 07:48:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201027/64de1116/attachment.htm>