This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20924 ) Change subject: bsc_subscr_conn_fsm: use cause code PREEMPTION on lchan loss ...................................................................... bsc_subscr_conn_fsm: use cause code PREEMPTION on lchan loss When an lchan gets lost, the clear request is currently using the cause code GSM0808_CAUSE_EQUIPMENT_FAILURE, depending on the type of MSC that is connected it could be possible that a cause code like this is interpreted a total failure of the BSC. Lets use GSM0808_CAUSE_PREEMPTION as cause code instead. Change-Id: I13216fdf5f99c027a420c5a1e3970a6a6f90d2af OS#4549 SYS#4914 Change-Id: I88b47695877a31bc5ede1080027c9c6080eb2090 --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/20924/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index ed08e86..075d419 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -374,7 +374,7 @@ LOGPFSML(fi, LOGL_INFO, "Connection confirmed but lchan was dropped previously, clearing conn\n"); osmo_fsm_inst_state_chg(conn->fi, ST_CLEARING, 60, -4); - gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); + gscon_bssmap_clear(conn, GSM0808_CAUSE_PREEMPTION); break; } @@ -740,7 +740,7 @@ /* fall thru, omit an error log if already in ST_CLEARING */ case ST_CLEARING: /* Request a Clear Command from the MSC. */ - gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); + gscon_bssmap_clear(conn, GSM0808_CAUSE_PREEMPTION); break; } } @@ -783,7 +783,7 @@ && !conn->ho.new_lchan && !conn->assignment.new_lchan && !conn->lcs.loc_req) - gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); + gscon_bssmap_clear(conn, GSM0808_CAUSE_PREEMPTION); } static void gscon_forget_mgw_endpoint(struct gsm_subscriber_connection *conn) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I88b47695877a31bc5ede1080027c9c6080eb2090 Gerrit-Change-Number: 20924 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201026/9944ae4f/attachment.htm>