Change in osmo-pcu[master]: tbf: Make window() available to tbf base class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Oct 25 08:45:37 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20856 )

Change subject: tbf: Make window() available to tbf base class
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20856/2/src/tbf.h 
File src/tbf.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/20856/2/src/tbf.h@188 
PS2, Line 188: virtual gprs_rlc_window
I am wondering if it's possible to define something like as_ul_tbf() and as_dl_tbf() here, so there would be no need to use static_cast everywhere...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20856
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e1decf91be1184668e28297c2126affb9c7ae4
Gerrit-Change-Number: 20856
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sun, 25 Oct 2020 08:45:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201025/411aaeb7/attachment.htm>


More information about the gerrit-log mailing list