Change in osmo-bts[master]: main: increase spacing between commands and description

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Oct 24 19:46:44 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20866 )

Change subject: main: increase spacing between commands and description
......................................................................

main: increase spacing between commands and description

Otherwise it's hard to fit new options with long names.

Change-Id: If9a418545abff6d22602ba07cfd4447f5ace7742
Related: SYS#4910
---
M src/common/main.c
M src/osmo-bts-litecell15/main.c
M src/osmo-bts-oc2g/main.c
M src/osmo-bts-octphy/main.c
M src/osmo-bts-sysmo/main.c
5 files changed, 22 insertions(+), 20 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/common/main.c b/src/common/main.c
index c7b821e..b1b1766 100644
--- a/src/common/main.c
+++ b/src/common/main.c
@@ -67,16 +67,16 @@
 static void print_help()
 {
 	printf( "Some useful options:\n"
-		"  -h	--help		this text\n"
-		"  -d	--debug MASK	Enable debugging (e.g. -d DRSL:DOML:DLAPDM)\n"
-		"  -D	--daemonize	For the process into a background daemon\n"
-		"  -c	--config-file 	Specify the filename of the config file\n"
-		"  -s	--disable-color	Don't use colors in stderr log output\n"
-		"  -T	--timestamp	Prefix every log line with a timestamp\n"
-		"  -V	--version	Print version information and exit\n"
-		"  -e 	--log-level	Set a global log-level\n"
-		"  -i	--gsmtap-ip	The destination IP used for GSMTAP.\n"
-		"    	--vty-ref-xml   Generate the VTY reference XML output and exit.\n"
+		"  -h	--help			this text\n"
+		"  -d	--debug MASK		Enable debugging (e.g. -d DRSL:DOML:DLAPDM)\n"
+		"  -D	--daemonize		For the process into a background daemon\n"
+		"  -c	--config-file 		Specify the filename of the config file\n"
+		"  -s	--disable-color		Don't use colors in stderr log output\n"
+		"  -T	--timestamp		Prefix every log line with a timestamp\n"
+		"  -V	--version		Print version information and exit\n"
+		"  -e 	--log-level		Set a global log-level\n"
+		"  -i	--gsmtap-ip		The destination IP used for GSMTAP.\n"
+		"    	--vty-ref-xml   	Generate the VTY reference XML output and exit.\n"
 		);
 	bts_model_print_help();
 }
diff --git a/src/osmo-bts-litecell15/main.c b/src/osmo-bts-litecell15/main.c
index a4f04e7..649557b 100644
--- a/src/osmo-bts-litecell15/main.c
+++ b/src/osmo-bts-litecell15/main.c
@@ -158,9 +158,10 @@
 
 void bts_model_print_help()
 {
-	printf( "  -w	--hw-version	Print the targeted HW Version\n"
-		"  -M	--pcu-direct	Force PCU to access message queue for PDCH dchannel directly\n"
-		"  -p	--dsp-trace 	Set DSP trace flags\n"
+	printf( "  -w	--hw-version		Print the targeted HW Version\n"
+		"  -M	--pcu-direct		Force PCU to access message queue for "
+						"PDCH dchannel directly\n"
+		"  -p	--dsp-trace		Set DSP trace flags\n"
 		);
 }
 
diff --git a/src/osmo-bts-oc2g/main.c b/src/osmo-bts-oc2g/main.c
index efbe180..d074ed3 100644
--- a/src/osmo-bts-oc2g/main.c
+++ b/src/osmo-bts-oc2g/main.c
@@ -159,9 +159,10 @@
 
 void bts_model_print_help()
 {
-	printf( "  -w	--hw-version	Print the targeted HW Version\n"
-		"  -M	--pcu-direct	Force PCU to access message queue for PDCH dchannel directly\n"
-		"  -p	--dsp-trace 	Set DSP trace flags\n"
+	printf( "  -w	--hw-version		Print the targeted HW Version\n"
+		"  -M	--pcu-direct		Force PCU to access message queue for "
+						"PDCH dchannel directly\n"
+		"  -p	--dsp-trace 		Set DSP trace flags\n"
 		);
 }
 
diff --git a/src/osmo-bts-octphy/main.c b/src/osmo-bts-octphy/main.c
index 928a4c8..caf0f8d 100644
--- a/src/osmo-bts-octphy/main.c
+++ b/src/osmo-bts-octphy/main.c
@@ -55,7 +55,7 @@
 
 int bts_model_print_help()
 {
-	printf("  -I	--no-fw-check	Override firmware version check\n");
+	printf("  -I	--no-fw-check		Override firmware version check\n");
 	return 0;
 }
 
diff --git a/src/osmo-bts-sysmo/main.c b/src/osmo-bts-sysmo/main.c
index 735768c..306e557 100644
--- a/src/osmo-bts-sysmo/main.c
+++ b/src/osmo-bts-sysmo/main.c
@@ -122,9 +122,9 @@
 void bts_model_print_help()
 {
 	printf(
-		"  -w	--hw-version	Print the targeted HW Version\n"
-		"  -M	--pcu-direct	Force PCU to access message queue for "
-			"PDCH dchannel directly\n"
+		"  -w	--hw-version		Print the targeted HW Version\n"
+		"  -M	--pcu-direct		Force PCU to access message queue for "
+						"PDCH dchannel directly\n"
 	      );
 };
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If9a418545abff6d22602ba07cfd4447f5ace7742
Gerrit-Change-Number: 20866
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201024/89269cd9/attachment.htm>


More information about the gerrit-log mailing list