This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20874 ) Change subject: device/uhd: re-introduce OSMO_ASSERT() in async_event_loop() ...................................................................... Patch Set 2: > Patch Set 2: Code-Review-2 > > It breaks the uhd ipc test backend because that does not have a vty nor does it need one, and the change was squashed at the time because that was what people wanted and it was reviewed at the time, so please do not just undo changes that were part of larger patchsets that led to known working releases. I must admit that it's not obvious. I found the change [1] now, and IMHO it would have been better to merge that patch separately. Or at least add a comment to the code explaining why we should not assert() there, unlike all other invocations of osmo_cpu_sched_vty_apply_localthread(). [1] https://gerrit.osmocom.org/c/osmo-trx/+/19649 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I424233074cad42ae1520c92d6e627eb983303478 Gerrit-Change-Number: 20874 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 24 Oct 2020 14:02:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201024/d6773afd/attachment.htm>