Change in osmo-sgsn[master]: process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was alr...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Oct 23 11:27:32 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20844 )


Change subject: process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was already released
......................................................................

process_ms_ctx_status: Fix crash deleting PDP Ctx if GTP side was already released

sgsn_delete_pdp_ctx() should never be called without checking if the GTP
side is available, since it may happen that it has already been released
by the time the mmctx tells us the pdp ctx is gone on the MS side.

Fixes: OS#4817
Change-Id: Ie618874545172ec98355174a2ee041fc4a8bec16
---
M src/sgsn/gprs_gmm.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/44/20844/1

diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index 0ad6003..3f7c8ab 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -1533,7 +1533,10 @@
 		LOGMMCTXP(LOGL_NOTICE, mmctx, "Dropping PDP context for NSAPI=%u "
 			"due to PDP CTX STATUS IE=0x%02x%02x\n",
 			pdp->nsapi, pdp_status[1], pdp_status[0]);
-		sgsn_delete_pdp_ctx(pdp);
+		if (pdp->ggsn)
+			sgsn_delete_pdp_ctx(pdp);
+		else /* GTP side already detached, freeing */
+			sgsn_pdp_ctx_free(pdp);
 	}
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20844
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie618874545172ec98355174a2ee041fc4a8bec16
Gerrit-Change-Number: 20844
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201023/ffbc117b/attachment.htm>


More information about the gerrit-log mailing list