This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20826 ) Change subject: oml: Set NM_OPSTATE_DISABLED by default ...................................................................... oml: Set NM_OPSTATE_DISABLED by default Otherwise, some objects are announced at startup of osmo-bts towards BSC during State Changed Report as being "NULL". According to TS 12.21: "NULL(Operat. state not supported) FF" Which doesn't make much sense in startup situation. They are in known state Disabled until they are OPSTARTed. Change-Id: I5ba6756ea069d0f995f453ee4b27e6839c914eb1 --- M src/common/bts.c M src/common/oml.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/common/bts.c b/src/common/bts.c index a1f29ff..6c25cbd 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -356,9 +356,9 @@ oml_mo_state_init(&bts->mo, NM_OPSTATE_DISABLED, NM_AVSTATE_NOT_INSTALLED); /* set BTS attr to dependency */ - oml_mo_state_init(&bts->gprs.nse.mo, -1, NM_AVSTATE_DEPENDENCY); - oml_mo_state_init(&bts->gprs.cell.mo, -1, NM_AVSTATE_DEPENDENCY); - oml_mo_state_init(&bts->gprs.nsvc[0].mo, -1, NM_AVSTATE_DEPENDENCY); + oml_mo_state_init(&bts->gprs.nse.mo, NM_OPSTATE_DISABLED, NM_AVSTATE_DEPENDENCY); + oml_mo_state_init(&bts->gprs.cell.mo, NM_OPSTATE_DISABLED, NM_AVSTATE_DEPENDENCY); + oml_mo_state_init(&bts->gprs.nsvc[0].mo, NM_OPSTATE_DISABLED, NM_AVSTATE_DEPENDENCY); oml_mo_state_init(&bts->gprs.nsvc[1].mo, NM_OPSTATE_DISABLED, NM_AVSTATE_OFF_LINE); /* allocate a talloc pool for ORTP to ensure it doesn't have to go back diff --git a/src/common/oml.c b/src/common/oml.c index e48f943..02b1770 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1562,7 +1562,7 @@ mo->obj_inst.bts_nr = p1; mo->obj_inst.trx_nr = p2; mo->obj_inst.ts_nr = p3; - mo->nm_state.operational = NM_OPSTATE_NULL; + mo->nm_state.operational = NM_OPSTATE_DISABLED; mo->nm_state.availability = NM_AVSTATE_POWER_OFF; mo->nm_state.administrative = NM_STATE_LOCKED; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5ba6756ea069d0f995f453ee4b27e6839c914eb1 Gerrit-Change-Number: 20826 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201022/ecf38ec1/attachment.htm>