This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20824 ) Change subject: bts_trx.c: Dispatch missing NM_EV_RSL_UP/DOWN to the bb_transc object ...................................................................... bts_trx.c: Dispatch missing NM_EV_RSL_UP/DOWN to the bb_transc object Previous commit 7810a917331b33b6cfab5259b5fb2df73b27b230 forgot to introduce this line, though it was planned to be there. Most of the time it worked fine anyway because the RSL link is not the last event bb_transc waits for before switching to Enabled, so later events would trigger inside the bb_transc fsm a recheck (polling) which wuld allow to advance to Enabled state. However, in the situation where RSL link UP is the last event to happen, no more inside-FSM checks are triggered and hence BB Transeiver never goes to Enabled state, and as a result no event is triggered towards each RadioChannel which in turn don't go to Enabled state. Fixes: 7810a917331b33b6cfab5259b5fb2df73b27b230 Change-Id: I8c777b946e7abcb4b607ec4d136c981a0716b120 --- M src/common/bts_trx.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/bts_trx.c b/src/common/bts_trx.c index 6bb18a3..38fb90a 100644 --- a/src/common/bts_trx.c +++ b/src/common/bts_trx.c @@ -199,6 +199,7 @@ link ? "up" : "down"); osmo_fsm_inst_dispatch(trx->mo.fi, link ? NM_EV_RSL_UP : NM_EV_RSL_DOWN, NULL); + osmo_fsm_inst_dispatch(trx->bb_transc.mo.fi, link ? NM_EV_RSL_UP : NM_EV_RSL_DOWN, NULL); if (link) rc = rsl_tx_rf_res(trx); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8c777b946e7abcb4b607ec4d136c981a0716b120 Gerrit-Change-Number: 20824 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201021/fd1c87c3/attachment.htm>