This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20732 ) Change subject: select: Migrate over to poll() ...................................................................... Patch Set 5: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/20732/5/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/20732/5/src/select.c@46 PS5, Line 46: #include <poll.h> #ifndef FORCE_IO_SELECT I think it may make sense to have select/poll specific stuff in different fails, it's easier to understand then what's generic and what's loop implementation specific. https://gerrit.osmocom.org/c/libosmocore/+/20732/5/src/select.c@159 PS5, Line 159: memset(p + g_poll.poll_size, 0, new_size - g_poll.poll_size); so is talloc_realloc doing a memcpy of previous chunk into the new chunk? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9e80da68a144b36926066610d0d3df06abe09bca Gerrit-Change-Number: 20732 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Oct 2020 18:50:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/33e69cb5/attachment.htm>