Change in osmo-msc[master]: emergency: set route-to-msisdn MSISDN to "emergency" by default.

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/20672 )

Change subject: emergency: set route-to-msisdn MSISDN to "emergency" by default.
......................................................................


Patch Set 3: -Code-Review

> Patch Set 3:
> 
> (1 comment)
> 
> > Patch Set 3:
> > 
> > So is "emergency" a valid MSISDN?
> 
> I don't think so, but keith says that osmo-sip-connector needs this MSISDN to act properly.

Yeah, I had also considered this. "emergency" may not be a valid MSISDN, but i'm pretty sure it's a valid user part of a sip address.

 The point though, is not to "fix" sip-connector. - but rather if the patch was merged with "112" as the number, then rhizomatica's downstream dialplan will get "112" rather than "emergency". Of course that can be "fixed" - and anyway, rhizomatica is still not using osmo-msc so it does not matter.

I was just pointing out that it would be a "breaking" change. But I'm fine also with the default being "112"

Actually, I have a feeling that "emergency" might have come from LCR?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/20672
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a600cef105c0d67a9991e14b2187e26eacb01ec
Gerrit-Change-Number: 20672
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Oct 2020 17:30:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/3a49b27f/attachment.htm>