This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20732 ) Change subject: select: Migrate over to poll() ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c@158 PS2, Line 158: g_poll.poll_size + POLL_ALLOC_GRANULARITY); > what would be the advantage? I don't really care much either way. A process starting to alocate big quantities of fds is expected to keep allocating lots more, so you adapt the number of reallocations based on that (meaning for processes with lots of fds you don't end up calling realloc lots of times, incrementing 1024 at a time). https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c@363 PS2, Line 363: rc = poll(g_poll.poll, n_poll, polling ? 0 : osmo_timers_nearest_ms()); > keeping multiple implementations around has the risk that over time only one of them will be tested […] Agree with moving to epoll at some point in time, but still I'd keep the select() support around which may come handy at any point, and it's not really a lot of specific code to keep anyway. At least let's have that for a while and drop it in a different patch to it's clear what's needed to readd it if somebody needs it. This way we ensure we are prepared to support several backends, which will require once we add an epoll implementation since that's linux-specific afaik and we'll need to keep something else for older linux versions too. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9e80da68a144b36926066610d0d3df06abe09bca Gerrit-Change-Number: 20732 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Oct 2020 10:17:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/496d3a97/attachment.htm>