This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20729 ) Change subject: power_control: do nothing if 'rx-current' equals 'rx-target' ...................................................................... Patch Set 2: -Code-Review (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/20729/2/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/20729/2/src/common/power_control.c@157 PS2, Line 157: return 0; Aren't you missing a call to bts_model_adjst_ms_pwr(lchan); here? Or why is the "lchan->ms_power_ctrl.current = ms_power_lvl;" needed? Perhaps goto to the end here where the new_power_lvl is set would be enough. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id99c7013a722403e773df8367b1a9d7a856e639b Gerrit-Change-Number: 20729 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Oct 2020 09:08:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/8e9ebac0/attachment.htm>